STEMMechanics/Website
1
0
Fork 0
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases 3 Wiki Activity

better error handling

Browse Source
This commit is contained in:
James Collins
2023-10-19 19:20:17 +10:00
parent 8c910ed5f3
commit 114db744b4
3 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/Http/Controllers/Api/MediaController.php
View File

@@ -184,6 +184,7 @@ class MediaController extends ApiController
array_key_exists('mime_type', $data) === true &&
$data['mime_type'] !== "") {
$error = Media::verifyStorage($data['mime_type'], $data['security']['type'], $data['storage']);
// Log::error($data['mime_type'] . ' - ' . $data['security']['type'] . ' - ' . $data['storage']);
switch($error) {
case Media::STORAGE_VALID:
break;
@@ -192,7 +193,7 @@ class MediaController extends ApiController
case Media::STORAGE_NOT_FOUND:
return $this->respondWithErrors(['storage' => 'Storage was not found.']);
case Media::STORAGE_INVALID_SECURITY:
return $this->respondWithErrors(['storage' => 'Storage invalid for security value.']);
return $this->respondWithErrors(['storage' => 'Storage invalid for this security requirement.']);
default:
return $this->respondWithErrors(['storage' => 'Storage verification error occurred.']);
}

7
app/Models/Media.php
View File

@@ -1020,11 +1020,8 @@ class Media extends Model
$storage = 'private';
}
} else {
try {
if(Storage::disk($storage)->exists('') === false) {
return Media::STORAGE_NOT_FOUND;
}
} catch(\Exception $e) {
$disks = config('filesystems.disks');
if(array_key_exists($storage, $disks) === false) {
return Media::STORAGE_NOT_FOUND;
}