From b7fde520bef72e83cbdf8a31812689ca6b4e92a9 Mon Sep 17 00:00:00 2001
From: James Collins <james.collins@outlook.com.au>
Date: Fri, 23 Jun 2023 08:44:44 +1000
Subject: [PATCH] add type=button to button elements

---
 resources/js/components/SMNavbar.vue                   |  1 +
 .../js/components/dialogs/SMDialogChangePassword.vue   |  2 +-
 resources/js/components/dialogs/SMDialogConfirm.vue    |  2 ++
 resources/js/components/dialogs/SMDialogMedia.vue      |  2 ++
 resources/js/views/Blog.vue                            |  1 +
 resources/js/views/MinecraftCurve.vue                  |  1 +
 resources/js/views/dashboard/AnalyticsList.vue         |  1 +
 resources/js/views/dashboard/ArticleList.vue           |  3 +++
 resources/js/views/dashboard/DiscordBotLogs.vue        |  2 +-
 resources/js/views/dashboard/EventList.vue             |  5 +++++
 resources/js/views/dashboard/MediaList.vue             | 10 ++++++----
 resources/js/views/dashboard/ShortlinkList.vue         |  4 ++++
 resources/js/views/dashboard/UserEdit.vue              |  1 +
 resources/js/views/dashboard/UserList.vue              |  3 +++
 14 files changed, 32 insertions(+), 6 deletions(-)

diff --git a/resources/js/components/SMNavbar.vue b/resources/js/components/SMNavbar.vue
index f8e56d5..dc1c59e 100644
--- a/resources/js/components/SMNavbar.vue
+++ b/resources/js/components/SMNavbar.vue
@@ -243,6 +243,7 @@
                         Find Workshops
                     </router-link>
                     <button
+                        type="button"
                         title="Toggle nav"
                         id="navbar-toggle"
                         class="leading-0 ml-4 mr-2 bg-transparent cursor-pointer"
diff --git a/resources/js/components/dialogs/SMDialogChangePassword.vue b/resources/js/components/dialogs/SMDialogChangePassword.vue
index d4ae791..d023866 100644
--- a/resources/js/components/dialogs/SMDialogChangePassword.vue
+++ b/resources/js/components/dialogs/SMDialogChangePassword.vue
@@ -13,7 +13,7 @@
                     autofocus />
             </template>
             <template #footer-space-between>
-                <button @click="handleClickCancel">Cancel</button>
+                <button type="button" @click="handleClickCancel">Cancel</button>
                 <input role="button" type="submit" value="Update" />
             </template>
         </SMFormCard>
diff --git a/resources/js/components/dialogs/SMDialogConfirm.vue b/resources/js/components/dialogs/SMDialogConfirm.vue
index 47bca40..d3aac7c 100644
--- a/resources/js/components/dialogs/SMDialogConfirm.vue
+++ b/resources/js/components/dialogs/SMDialogConfirm.vue
@@ -8,11 +8,13 @@
             <p class="mb-4" v-html="props.text"></p>
             <div class="flex flex-justify-between pt-4">
                 <button
+                    type="button"
                     class="font-medium px-6 py-1.5 rounded-md hover:shadow-md transition text-sm bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                     @click="handleClickCancel()">
                     {{ props.cancel.label }}
                 </button>
                 <button
+                    type="button"
                     class="font-medium px-6 py-1.5 rounded-md hover:shadow-md transition text-sm bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                     @click="handleClickConfirm()">
                     {{ props.confirm.label }}
diff --git a/resources/js/components/dialogs/SMDialogMedia.vue b/resources/js/components/dialogs/SMDialogMedia.vue
index 4e6144a..80b14fb 100644
--- a/resources/js/components/dialogs/SMDialogMedia.vue
+++ b/resources/js/components/dialogs/SMDialogMedia.vue
@@ -32,6 +32,7 @@
                                 @blur="handleSearch">
                                 <template #append>
                                     <button
+                                        type="button"
                                         class="font-medium px-4 py-3.1 rounded-r-2 hover:shadow-md transition bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                                         @click="handleSearch">
                                         <svg
@@ -104,6 +105,7 @@
                                             backgroundImage: `url(${uploadPreview})`,
                                         }"></div>
                                     <button
+                                        type="button"
                                         v-if="props.allowUpload"
                                         @click="handleClickSelectFile">
                                         Select File
diff --git a/resources/js/views/Blog.vue b/resources/js/views/Blog.vue
index 33f3d1d..becb96a 100644
--- a/resources/js/views/Blog.vue
+++ b/resources/js/views/Blog.vue
@@ -10,6 +10,7 @@
                 @blur="handleSearch">
                 <template #append
                     ><button
+                        type="button"
                         class="font-medium px-4 py-3.1 rounded-r-2 hover:shadow-md transition bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                         @click="handleSearch">
                         <svg
diff --git a/resources/js/views/MinecraftCurve.vue b/resources/js/views/MinecraftCurve.vue
index 9a04452..544b02e 100644
--- a/resources/js/views/MinecraftCurve.vue
+++ b/resources/js/views/MinecraftCurve.vue
@@ -83,6 +83,7 @@
                 </div>
 
                 <button
+                    type="button"
                     class="mt-4 font-medium px-6 py-1.5 rounded-md hover:shadow-md transition text-sm bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                     @click="handleClickButton">
                     Copy curve
diff --git a/resources/js/views/dashboard/AnalyticsList.vue b/resources/js/views/dashboard/AnalyticsList.vue
index cc116b8..335ef9c 100644
--- a/resources/js/views/dashboard/AnalyticsList.vue
+++ b/resources/js/views/dashboard/AnalyticsList.vue
@@ -14,6 +14,7 @@
                     @keyup.enter="handleSearch">
                     <template #append>
                         <button
+                            type="button"
                             class="font-medium px-4 py-3.1 rounded-r-2 hover:shadow-md transition bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                             @click="handleSearch">
                             <svg
diff --git a/resources/js/views/dashboard/ArticleList.vue b/resources/js/views/dashboard/ArticleList.vue
index 15876bf..1573614 100644
--- a/resources/js/views/dashboard/ArticleList.vue
+++ b/resources/js/views/dashboard/ArticleList.vue
@@ -20,6 +20,7 @@
                     @keyup.enter="handleSearch">
                     <template #append>
                         <button
+                            type="button"
                             class="font-medium px-4 py-3.1 rounded-r-2 hover:shadow-md transition bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                             @click="handleSearch">
                             <svg
@@ -60,6 +61,7 @@
                 <SMTable :headers="headers" :items="items">
                     <template #item-actions="item">
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-sky-5"
                             title="Edit"
                             @click="handleEdit(item)">
@@ -73,6 +75,7 @@
                             </svg>
                         </button>
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-red-7"
                             title="Delete"
                             @click="handleDelete(item)">
diff --git a/resources/js/views/dashboard/DiscordBotLogs.vue b/resources/js/views/dashboard/DiscordBotLogs.vue
index c953f35..f29c80d 100644
--- a/resources/js/views/dashboard/DiscordBotLogs.vue
+++ b/resources/js/views/dashboard/DiscordBotLogs.vue
@@ -21,7 +21,7 @@
                     </SMTabGroup>
                 </SMColumn>
             </SMRow>
-            <button @click="loadData">Reload Logs</button>
+            <button type="button" @click="loadData">Reload Logs</button>
         </SMContainer>
     </SMPage>
 </template>
diff --git a/resources/js/views/dashboard/EventList.vue b/resources/js/views/dashboard/EventList.vue
index e1a83a6..6d3e69d 100644
--- a/resources/js/views/dashboard/EventList.vue
+++ b/resources/js/views/dashboard/EventList.vue
@@ -20,6 +20,7 @@
                     @keyup.enter="handleSearch">
                     <template #append>
                         <button
+                            type="button"
                             class="font-medium px-4 py-3.1 rounded-r-2 hover:shadow-md transition bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                             @click="handleSearch">
                             <svg
@@ -65,6 +66,7 @@
                     </template>
                     <template #item-actions="item">
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-sky-5"
                             title="Edit"
                             @click="handleEdit(item)">
@@ -78,6 +80,7 @@
                             </svg>
                         </button>
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-sky-5"
                             title="View"
                             @click="handleView(item)">
@@ -91,6 +94,7 @@
                             </svg>
                         </button>
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-sky-5"
                             title="Duplicate"
                             @click="handleDuplicate(item)">
@@ -104,6 +108,7 @@
                             </svg>
                         </button>
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-red-7"
                             title="Delete"
                             @click="handleDelete(item)">
diff --git a/resources/js/views/dashboard/MediaList.vue b/resources/js/views/dashboard/MediaList.vue
index 13b22c6..01ffe35 100644
--- a/resources/js/views/dashboard/MediaList.vue
+++ b/resources/js/views/dashboard/MediaList.vue
@@ -20,6 +20,7 @@
                     @keyup.enter="handleSearch">
                     <template #append>
                         <button
+                            type="button"
                             class="font-medium px-4 py-3.1 rounded-r-2 hover:shadow-md transition bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                             @click="handleSearch">
                             <svg
@@ -75,6 +76,7 @@
                     >
                     <template #item-actions="item">
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-sky-5"
                             title="Edit"
                             @click="handleEdit(item)">
@@ -88,6 +90,7 @@
                             </svg>
                         </button>
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-sky-5"
                             title="Download"
                             @click="handleDownload(item)">
@@ -101,6 +104,7 @@
                             </svg>
                         </button>
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-red-7"
                             title="Delete"
                             @click="handleDelete(item)">
@@ -118,15 +122,13 @@
                 <div class="align-items-center">
                     <div>
                         <button
-                            type="danger"
-                            label="Delete Selected"
+                            type="button"
                             :disabled="computedSelectedCount == 0"
                             @click="handleDeleteSelected">
                             Delete Selected
                         </button>
                         <button
-                            type="primary"
-                            label="Edit Selected"
+                            type="button"
                             :disabled="computedSelectedCount == 0"
                             @click="handleEditSelected">
                             Edit Selected
diff --git a/resources/js/views/dashboard/ShortlinkList.vue b/resources/js/views/dashboard/ShortlinkList.vue
index abe8891..c61be5e 100644
--- a/resources/js/views/dashboard/ShortlinkList.vue
+++ b/resources/js/views/dashboard/ShortlinkList.vue
@@ -20,6 +20,7 @@
                     @keyup.enter="handleSearch">
                     <template #append>
                         <button
+                            type="button"
                             class="font-medium px-4 py-3.1 rounded-r-2 hover:shadow-md transition bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                             @click="handleSearch">
                             <svg
@@ -62,6 +63,7 @@
                     :items="items">
                     <template #item-actions="item">
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-sky-5"
                             title="Edit"
                             @click="handleEdit(item)">
@@ -75,6 +77,7 @@
                             </svg>
                         </button>
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-sky-5"
                             title="Copy Shortlink"
                             @click="handleCopy(item)">
@@ -88,6 +91,7 @@
                             </svg>
                         </button>
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-red-7"
                             title="Delete"
                             @click="handleDelete(item)">
diff --git a/resources/js/views/dashboard/UserEdit.vue b/resources/js/views/dashboard/UserEdit.vue
index 4d76f83..3ac20a8 100644
--- a/resources/js/views/dashboard/UserEdit.vue
+++ b/resources/js/views/dashboard/UserEdit.vue
@@ -44,6 +44,7 @@
                 </template>
                 <div class="flex flex-justify-between mt-8">
                     <button
+                        type="button"
                         v-if="!isCreating"
                         class="font-medium px-6 py-1.5 rounded-md hover:shadow-md transition text-sm bg-white border-1 border-sky-500 text-sky-500 cursor-pointer"
                         @click="handleChangePassword">
diff --git a/resources/js/views/dashboard/UserList.vue b/resources/js/views/dashboard/UserList.vue
index c21801e..d4ce4da 100644
--- a/resources/js/views/dashboard/UserList.vue
+++ b/resources/js/views/dashboard/UserList.vue
@@ -20,6 +20,7 @@
                     @keyup.enter="handleSearch">
                     <template #append>
                         <button
+                            type="button"
                             class="font-medium px-4 py-3.1 rounded-r-2 hover:shadow-md transition bg-sky-600 hover:bg-sky-500 text-white cursor-pointer"
                             @click="handleSearch">
                             <svg
@@ -59,6 +60,7 @@
                 <SMTable :headers="headers" :items="items">
                     <template #item-actions="item">
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-sky-5"
                             title="Edit"
                             @click="handleEdit(item)">
@@ -72,6 +74,7 @@
                             </svg>
                         </button>
                         <button
+                            type="button"
                             class="bg-transparent cursor-pointer hover:text-red-7"
                             title="Delete"
                             @click="handleDelete(item)">