STEMMechanics/Website
1
0
Fork 0
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases 3 Wiki Activity

PHPUnit 10 Shift #51

Merged
nomadjimbob merged 2 commits from shift-91888 into main 2023-05-24 21:53:54 +00:00
Conversation 5 Commits 2 Files Changed 7 +7 -7
nomadjimbob commented 2023-05-24 21:53:19 +00:00 (Migrated from github.com)
Copy Link

This pull request contains changes for upgrading to PHPUnit 10 automated by the PHPUnit 10 Shift.

Before merging, you need to:

  • Checkout the shift-91888 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, add --no-scripts)
  • Run your tests suite: vendor/bin/phpunit

If there were changes you felt could have been automated, please reply to the follow-up email with your feedback or on Twitter.

This pull request contains changes for upgrading to [PHPUnit 10](https://phpunit.de/announcements/phpunit-10.html) automated by the [PHPUnit 10 Shift](https://laravelshift.com/upgrade-phpunit-10). **Before merging**, you need to: - Checkout the `shift-91888` branch - Review **all** pull request comments for additional changes - Run `composer update` (if the scripts fail, add `--no-scripts`) - Run your tests suite: `vendor/bin/phpunit` If there were changes you felt could have been automated, please reply to the follow-up email with your feedback or on [Twitter](https://twitter.com/laravelshift).
nomadjimbob commented 2023-05-24 21:53:20 +00:00 (Migrated from github.com)
Copy Link

⚠️ PHPUnit 10 has made several changes to the configuration file. After running composer update, you may run vendor/bin/phpunit --migrate-configuration to have PHPUnit upgrade your configuration file.

:warning: PHPUnit 10 has made several changes to the configuration file. After running `composer update`, you may run `vendor/bin/phpunit --migrate-configuration` to have PHPUnit upgrade your configuration file.
nomadjimbob commented 2023-05-24 21:53:21 +00:00 (Migrated from github.com)
Copy Link

ℹ️ PHPUnit has documented using return types for test cases and data providers since PHPUnit 8. In an effort to modernize your test suite, Shift added a return type of void to your test cases and a return type of array to your data providers.

Shift understands developers have different preferences when it comes to type hints. If you do not wish to add return types, you may undo this change by running git revert a3659777.

:information_source: PHPUnit has documented using return types for test cases and data providers since PHPUnit 8. In an effort to modernize your test suite, Shift added a return type of `void` to your test cases and a return type of `array` to your data providers. Shift understands developers have different preferences when it comes to type hints. If you do not wish to add return types, you may undo this change by running `git revert a3659777`.
nomadjimbob commented 2023-05-24 21:53:22 +00:00 (Migrated from github.com)
Copy Link

ℹ️ PHPUnit has documented declaring test classes as final since PHPUnit 8. In an effort to modernize your test suite, Shift has declared your test classes as final.

Shift understands developers have different preferences when it comes to using final. If you do not wish to declare your test classes as final, you may undo this change by running git revert 5e838ad6.

:information_source: PHPUnit has documented declaring test classes as `final` since PHPUnit 8. In an effort to modernize your test suite, Shift has declared your test classes as `final`. Shift understands developers have different preferences when it comes to using `final`. If you do not wish to declare your test classes as `final`, you may undo this change by running `git revert 5e838ad6`.
nomadjimbob commented 2023-05-24 21:53:22 +00:00 (Migrated from github.com)
Copy Link

⚠️ PHPUnit 10 now requires any base test class to have a TestCase suffix. In addition, this class should be defined as abstract. If you have a custom base test class, you should ensure it meets these new requirements.

:warning: PHPUnit 10 now requires any _base test class_ to have a _TestCase_ suffix. In addition, this class should be defined as `abstract`. If you have a custom base test class, you should ensure it meets these new requirements.
nomadjimbob commented 2023-05-24 21:53:23 +00:00 (Migrated from github.com)
Copy Link

⚗️ This Shift is still being refined. Please report any issues or suggestions to shift@laravelshift.com. Your feedback is what helps improve the experience for everyone.

:alembic: This Shift is still being refined. **Please report any issues or suggestions** to [shift@laravelshift.com](mailto:shift@laravelshift.com). Your feedback is what helps improve the experience for everyone.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update Javascript code
 php
Pull requests that update Php code
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
nomadjimbob renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: STEMMechanics/Website#51
Delete Branch "shift-91888"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?